fix(message): reject empty bodies - #397
Merged
schickling merged 1 commit intoAug 31, 2026
Merged
Conversation
agent-identity: dev3.direct.omp.vjwqaz7t agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.11 agent-runtime: OMP 18.0.11 tooling-profile: dotfiles@000f2b3
schickling-assistant
marked this pull request as ready for review
August 30, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
st2 message sendaccepted an empty-mvalue or empty stdin and published a valid headers-only message. The sender saw success, while the recipient received no message content.Goal
Reject an empty message before any recipient or sender artifact is written.
Verification
CI=1 nix develop -c cargo test --test message_cli send_rejects_empty_explicit_and_stdin_bodies_without_persisting_a_message -- --exact— 1 passednix flake check --print-build-logs --no-write-lock-file— passed all 16 Linux checksComplexity
No new complexity. Validation stays at the existing shared body-input boundary.
Concerns
Whitespace-only bodies and literal backslash-n byte sequences remain valid content. Shell escaping remains the caller's responsibility.
Friction & bottlenecks
Local Nix tracing emitted an ignored permissions warning. Validation itself passed.
Follow-ups
None.
References
Closes #226
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile